docs(skill): parameters must be dimensions, never absolute coordinates#71
Open
YLZha wants to merge 1 commit into
Open
docs(skill): parameters must be dimensions, never absolute coordinates#71YLZha wants to merge 1 commit into
YLZha wants to merge 1 commit into
Conversation
Add a Parameter Planning principle: every user parameter must be a measurable quantity (length, width, thickness, depth, gap, radius, angle, count) — never an absolute position like top_z/bottom_z. Coordinate parameters don't survive moving the model and silently break when a related dimension (e.g. table_h) changes while the literal stays put. Positions are derived in the build from dimensions + references; the only world-origin reference is the root (rule 10). Includes a litmus test. Prompted by a Ming-table build where literal sp_botz/slot_botz = 24.9 in distorted the spandrel/leg-slot joints on a height change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Parameter Planning principle to the woodworking skill: a user parameter must be a dimension (length, width, thickness, depth, gap, radius, angle, count) — never an absolute coordinate (
top_z,bottom_z,apron_top_z = 24.9 in).Why
A coordinate parameter is brittle in two ways:
table_hand a hardcodedsp_botz = 24.9 instays put while everything around it rises, silently distorting or breaking the joint.Positions should be derived in the build from dimensions and references (the spandrel bottom is
apron_bottom - spandrel_depth, not an absolutesp_botz); the only thing measured from the world origin is the root (legs on the floor, per rule 10). The rule includes a litmus test: "if the customer moved this table across the room, or made it 2 inches taller, would this value still be correct as written?"Prompted by a Ming-table build where literal
sp_botz/slot_botz = 24.9 indistorted the spandrel and leg-slot joints when the table height changed.🤖 Generated with Claude Code